AutoDJProcessor: Move DeckAttributes into its own file - #16861
Open
cr7pt0gr4ph7 wants to merge 4 commits into
Open
AutoDJProcessor: Move DeckAttributes into its own file#16861cr7pt0gr4ph7 wants to merge 4 commits into
cr7pt0gr4ph7 wants to merge 4 commits into
Conversation
This was referenced Aug 9, 2026
This is a first step in generalizing the transition logic in AutoDJProcessor to enable it to also be applied to tracks in the queue instead of just the current decks. The code of DeckAttributes has not been changed at all (yet), and is simply copy-pasted from autodjprocessor.(cpp|h).
cr7pt0gr4ph7
force-pushed
the
rtm_autodj_deckattributes
branch
from
August 11, 2026 09:45
e65b1f7 to
3839b34
Compare
Contributor
|
I would like to help move the AutoDJ improvements along. As a first step, I looked at this PR and since I don't see anything wrong, I'm giving this PR an LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple copy & paste (first commit) plus a few small additions (the remaining commits).
Split off on @daschuer's request from: #13183 (which has now been superseded by #16865).
This PR is the first in a five-part series that culminates in #16865 to display the accurate remaining play time of the Auto DJ queue in the UI.